[bug_fix] Missing resource from OpenShift Routes prevents them to be deployed in OpenShift clusters #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Israel Blancas <[email protected]>
Signed-off-by: Israel Blancas <[email protected]>
iblancasa
changed the title
frzifus
reviewed
Dec 22, 2022
There was a problem hiding this comment.
thanks @iblancasa , but a changelog is missing. Please run chlog-new and fill the created file. [adding a changelog entry]
Signed-off-by: Israel Blancas <[email protected]>
iblancasa
changed the title
frzifus
approved these changes
Jan 9, 2023
|
@iblancasa could you please paste here one links/docs for |
|
@pavolloffay I was not able to find documentation about this in the OpenShift documentation. When I tried to deploy the CR, the pods were not created. This is all the information I was able to collect from the Internet: |
pavolloffay
approved these changes
Jan 10, 2023
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…deployed in OpenShift clusters (open-telemetry#1337) * Add missing resource for OpenShift routes Signed-off-by: Israel Blancas <[email protected]> * Add missing file Signed-off-by: Israel Blancas <[email protected]> * Add missing changelog file Signed-off-by: Israel Blancas <[email protected]> Signed-off-by: Israel Blancas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1206 , OpenShift routes are supported by the OpenTelemetry Collector Operator.
In upstream, this works because we're installing the OpenShift Routes CRD in the Kubernetes cluster. But, for OpenShift, the creation of routes don't work.
How to reproduce
When this manifest is deployed:
This error is logged in the OTEL Collector Operator:
{"level":"error","ts":"2022-12-21T16:32:48.213626Z","msg":"Reconciler error","controller":"opentelemetrycollector","controllerGroup":"opentelemetry.io","controllerKind":"OpenTelemetryCollector","OpenTelemetryCollector":{"name":"simplest","namespace":"israel"},"namespace":"israel","name":"simplest","reconcileID":"83890790-0c84-49de-ace1-9c0c305e8d51","error":"failed to reconcile the expected routes: failed to create: Route.route.openshift.io \"otlp-grpc-simplest-route\" is invalid: spec.host: Forbidden: you do not have permission to set the host field of the route","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:326\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:273\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:234"}And the Collector nor the Route are created.
Environment
OCP version:
4.11Branch:
mainCommit:
06503f9eb1ff8dcaddcbb13c97a3fe9d5a7fbb18